From f1c12c8a196cf93f3e74ca127492cd3127a92319 Mon Sep 17 00:00:00 2001 From: benji7425 Date: Tue, 14 Nov 2017 01:31:42 +0000 Subject: [PATCH] Fix empty RSS feed crash --- CHANGELOG.md | 6 ++++++ app/models/feed-data.js | 17 ++++++++++------- package.json | 2 +- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e98ceb..eb39967 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## v3.1.1 + +### Fixed + +- Empty RSS feed crash + ## v3.1.0 ### Added diff --git a/app/models/feed-data.js b/app/models/feed-data.js index 99f745e..8c82a11 100644 --- a/app/models/feed-data.js +++ b/app/models/feed-data.js @@ -77,16 +77,19 @@ module.exports = class FeedData { return; } - const latest = normaliseUrl(articles[0].link); + if (articles.length > 0) { - if (!this.cachedLinks.includes(latest)) { - this.cachedLinks.push(latest); + const latest = normaliseUrl(articles[0].link); - const channel = guild.channels.get(this.channelID), - role = guild.roles.get(this.roleID); + if (!this.cachedLinks.includes(latest)) { + this.cachedLinks.push(latest); - channel.send((role || "") + formatPost(articles[0])) - .catch(err => DiscordUtil.dateError(`Error posting in ${channel.id}: ${err.message || err}`)); + const channel = guild.channels.get(this.channelID), + role = guild.roles.get(this.roleID); + + channel.send((role || "") + formatPost(articles[0])) + .catch(err => DiscordUtil.dateError(`Error posting in ${channel.id}: ${err.message || err}`)); + } } }); } diff --git a/package.json b/package.json index f227f15..a36263b 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "version": "3.1.0", + "version": "3.1.1", "main": "app/index.js", "scripts": { "postinstall": "cd ./discord-bot-core && npm install",